Issue 4626073: PDF Data for iOS and helper methods for samples in SampleApp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4626073: PDF Data for iOS and helper methods for samples in SampleApp (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by yangsu

Modified:
13 years ago

Reviewers:
Leon, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Updated files to use the new SkData instead of SkDataRef #

Total comments: 3

Patch Set 3 : Changed delete to unref #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -2 lines)			Patch
	M	samplecode/SampleApp.cpp	View	1 2	4 chunks	+31 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Leon

http://codereview.appspot.com/4626073/diff/3001/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): http://codereview.appspot.com/4626073/diff/3001/samplecode/SampleApp.cpp#newcode785 samplecode/SampleApp.cpp:785: SkFILEWStream stream(name.c_str()); Do you still want to create the ...

13 years ago (2011-06-24 15:28:00 UTC) #2

yangsu

http://codereview.appspot.com/4626073/diff/3001/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): http://codereview.appspot.com/4626073/diff/3001/samplecode/SampleApp.cpp#newcode963 samplecode/SampleApp.cpp:963: delete view; because fSamples[i]() calls the factory function that ...

13 years ago (2011-06-24 15:53:47 UTC) #3

lgtm

Expand All Messages | Collapse All Messages