Issue 4625048: Remember last successful stencil format

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4625048: Remember last successful stencil format (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bsalomon

Modified:
13 years ago

Reviewers:
reed1

CC:
Alok Priyadarshi

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -11 lines)			Patch
	M	gpu/src/GrGpuGL.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	gpu/src/GrGpuGL.cpp	View		9 chunks	+23 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

Is there a way to make this (tricky) logic clearer? Even a comment stating why ...

13 years ago (2011-06-17 18:05:37 UTC) #2

bsalomon

13 years ago (2011-06-17 18:12:41 UTC) #3

Committed at r1640 (with comments added)

On 2011/06/17 18:05:37, reed1 wrote:
> Is there a way to make this (tricky) logic clearer? Even a  comment stating
why
> its complicated, and/or why we cache the last successful one (and why we can't
> always just use it) would help.
> 
> LGTM

Expand All Messages | Collapse All Messages