Check IBUS_CONFIG_HOME environment variable when reading/writing the socket file.

Check IBUS_CONFIG_HOME environment variable when reading/writing the socket file.

BUG=crosbug.com/16501
TEST=export IBUS_CONFIG_HOME=/tmp, start Chrome on Chromium OS, verify an empty dir /tmp/ibus/bus exists with mode 0700, log in, enable IME, verify IME works, verify the socket file is created in /tmp/ibus/bus.

[satorux, 2011-06-15 05:23:52]

LGTM

http://codereview.appspot.com/4621043/diff/1/src/ibusshare.c
File src/ibusshare.c (right):

http://codereview.appspot.com/4621043/diff/1/src/ibusshare.c#newcode189
src/ibusshare.c:189: config_home = g_getenv ("IBUS_CONFIG_HOME");
For new code, would be nicer/safer to declare variables where these are used.
Let's use C99.

  const gchar *config_home = g_getenv ("IBUS_CONFIG_HOME");

[Yusuke Sato, 2011-06-15 05:26:49]

http://codereview.appspot.com/4621043/diff/1/src/ibusshare.c
File src/ibusshare.c (right):

http://codereview.appspot.com/4621043/diff/1/src/ibusshare.c#newcode189
src/ibusshare.c:189: config_home = g_getenv ("IBUS_CONFIG_HOME");
On 2011/06/15 05:23:52, satorux wrote:
> For new code, would be nicer/safer to declare variables where these are used.
> Let's use C99.
> 
>   const gchar *config_home = g_getenv ("IBUS_CONFIG_HOME");

Done.

[Peng, 2011-06-15 14:09:31]

http://codereview.appspot.com/4621043/diff/4001/src/ibusshare.c
File src/ibusshare.c (right):

http://codereview.appspot.com/4621043/diff/4001/src/ibusshare.c#newcode188
src/ibusshare.c:188: const gchar *config_home = g_getenv ("IBUS_CONFIG_HOME");
I think the variable name is not accurate. It looks like all ibus components
should respect it and use this path for storing config stuffs. but I think it is
only for address file, right? How about rename it to IBUS_ADDRESS_FILE (the file
for storing ibus address), and this function could return this value directly
instead of making the path from several parts?

[Yusuke Sato, 2011-06-16 11:18:19]

http://codereview.appspot.com/4621043/diff/4001/src/ibusshare.c
File src/ibusshare.c (right):

http://codereview.appspot.com/4621043/diff/4001/src/ibusshare.c#newcode188
src/ibusshare.c:188: const gchar *config_home = g_getenv ("IBUS_CONFIG_HOME");
On 2011/06/15 14:09:31, Peng wrote:
> I think the variable name is not accurate. It looks like all ibus components
> should respect it and use this path for storing config stuffs. but I think it
is
> only for address file, right? How about rename it to IBUS_ADDRESS_FILE (the
file
> for storing ibus address), and this function could return this value directly
> instead of making the path from several parts?

Done.

[Peng, 2011-06-16 14:22:21]

On 2011/06/16 11:18:19, Yusuke Sato wrote:
> http://codereview.appspot.com/4621043/diff/4001/src/ibusshare.c
> File src/ibusshare.c (right):
> 
> http://codereview.appspot.com/4621043/diff/4001/src/ibusshare.c#newcode188
> src/ibusshare.c:188: const gchar *config_home = g_getenv ("IBUS_CONFIG_HOME");
> On 2011/06/15 14:09:31, Peng wrote:
> > I think the variable name is not accurate. It looks like all ibus components
> > should respect it and use this path for storing config stuffs. but I think
it
> is
> > only for address file, right? How about rename it to IBUS_ADDRESS_FILE (the
> file
> > for storing ibus address), and this function could return this value
directly
> > instead of making the path from several parts?
> 
> Done.

LGTM. Thx