Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1329)

Issue 4620051: Fix breathing sign Y-offset when using line-positions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Neil Puttock
Modified:
12 years, 10 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix breathing sign Y-offset when using line-positions. * input/regression/breathing-sign-custom-staff.ly new regtest * lily/breathing-sign.cc (offset_callback): use Staff_symbol::line_span () to calculate offset instead of Staff_symbol_referencer::line_count (): the latter is only useful for symmetrical staves tidy code; remove obsolete TODO

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
A input/regression/breathing-sign-custom-staff.ly View 1 chunk +13 lines, -0 lines 0 comments Download
M lily/breathing-sign.cc View 2 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 2
Neil Puttock
This fixes issue #1696, ensuring breathing signs are always positioned on extremal staff lines.
12 years, 10 months ago (2011-06-15 21:42:09 UTC) #1
Neil Puttock
12 years, 10 months ago (2011-06-18 22:56:19 UTC) #2
Pushed: c1a48137f98086b46a91cf5b741c0b744409904b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b