Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(130)

Issue 4610045: delete manually-imported Gyp source (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by epoger
Modified:
13 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

As of http://code.google.com/p/skia/source/detail?r=1576 , we are using the automatically imported Gyp source in third_party/externals/gyp instead of the manually imported third_party/gyp . That seems to be working fine (in the buildbot, as well as in my own testing on Linux, Mac, and Windows), so it is now safe to delete the manually imported Gyp source code.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16656 lines) Patch
D third_party/gyp/AUTHORS View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/gyp/LICENSE View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/gyp/README.skia View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/gyp/gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/gyp/gyp.bat View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/gyp/pylib/gyp/MSVSNew.py View 1 chunk +0 lines, -341 lines 0 comments Download
D third_party/gyp/pylib/gyp/MSVSProject.py View 1 chunk +0 lines, -245 lines 0 comments Download
D third_party/gyp/pylib/gyp/MSVSSettings.py View 1 chunk +0 lines, -1034 lines 0 comments Download
D third_party/gyp/pylib/gyp/MSVSSettings_test.py View 1 chunk +0 lines, -1480 lines 0 comments Download
D third_party/gyp/pylib/gyp/MSVSToolFile.py View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/gyp/pylib/gyp/MSVSUserFile.py View 1 chunk +0 lines, -182 lines 0 comments Download
D third_party/gyp/pylib/gyp/MSVSVersion.py View 1 chunk +0 lines, -199 lines 0 comments Download
D third_party/gyp/pylib/gyp/SCons.py View 1 chunk +0 lines, -200 lines 0 comments Download
D third_party/gyp/pylib/gyp/__init__.py View 1 chunk +0 lines, -461 lines 0 comments Download
D third_party/gyp/pylib/gyp/common.py View 1 chunk +0 lines, -345 lines 0 comments Download
D third_party/gyp/pylib/gyp/easy_xml.py View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/gyp/pylib/gyp/easy_xml_test.py View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/gyp/pylib/gyp/generator/gypd.py View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/gyp/pylib/gyp/generator/gypsh.py View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/gyp/pylib/gyp/generator/make.py View 1 chunk +0 lines, -1423 lines 0 comments Download
D third_party/gyp/pylib/gyp/generator/msvs.py View 1 chunk +0 lines, -2731 lines 0 comments Download
D third_party/gyp/pylib/gyp/generator/scons.py View 1 chunk +0 lines, -1045 lines 0 comments Download
D third_party/gyp/pylib/gyp/generator/xcode.py View 1 chunk +0 lines, -1201 lines 0 comments Download
D third_party/gyp/pylib/gyp/input.py View 1 chunk +0 lines, -2250 lines 0 comments Download
D third_party/gyp/pylib/gyp/system_test.py View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/gyp/pylib/gyp/xcodeproj_file.py View 1 chunk +0 lines, -2840 lines 0 comments Download
D third_party/gyp/pylib/gyp/xml_fix.py View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/gyp/setup.py View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 3
epoger
13 years, 2 months ago (2011-06-14 17:52:04 UTC) #1
bsalomon
On 2011/06/14 17:52:04, epoger wrote: LGTM
13 years, 2 months ago (2011-06-14 17:53:35 UTC) #2
epoger
13 years, 2 months ago (2011-06-14 17:57:52 UTC) #3
committed as r1580
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b