Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(163)

Issue 4603050: code review 4603050: http: warn if the default Content-Type is known to be i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 12 months ago by dsymonds
Modified:
14 years, 11 months ago
Reviewers:
rsc
CC:
golang-dev
Visibility:
Public.

Description

http: warn if the default Content-Type is known to be incorrect. This logs a warning once per handler pattern per ServeMux. The sniffing here is very conservative. It could be made better in the future.

Patch Set 1 #

Patch Set 2 : diff -r dc2faaa6c26a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r dc2faaa6c26a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -7 lines) Patch
M src/pkg/http/server.go View 1 8 chunks +39 lines, -7 lines 0 comments Download

Messages

Total messages: 3
dsymonds
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 12 months ago (2011-06-14 03:01:21 UTC) #1
rsc
Thanks but no thanks. This kind of chattiness is definitely not the answer. Russ
14 years, 12 months ago (2011-06-14 14:07:53 UTC) #2
dsymonds
14 years, 11 months ago (2011-07-01 00:48:31 UTC) #3
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b