Issue 4602049: Use GL in the Android sample app.

Issue 4602049: Use GL in the Android sample app. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by DerekS

Modified:
13 years, 5 months ago

Reviewers:
Leon, bsalomon, scroggo, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Enhancements to the SampleApp #

Patch Set 3 : Add missing menu xml file #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+493 lines, -101 lines)			Patch
M	android_sample/SampleApp/Android.mk	View	1	2 chunks	+11 lines, -12 lines	0 comments	Download
M	android_sample/SampleApp/AndroidManifest.xml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	android_sample/SampleApp/jni/sample-jni.cpp	View		6 chunks	+48 lines, -13 lines	0 comments	Download
A	android_sample/SampleApp/res/menu/sample.xml	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
M	android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java	View	1	1 chunk	+103 lines, -46 lines	0 comments	Download
A	android_sample/SampleApp/src/com/skia/sampleapp/SampleView.java	View		1 chunk	+111 lines, -0 lines	0 comments	Download
A	gpu/src/android/GrGLDefaultInterface_android.cpp	View		1 chunk	+138 lines, -0 lines	0 comments	Download
M	include/utils/android/AndroidKeyToSkKey.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	include/views/SkOSWindow_Android.h	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	1	7 chunks	+40 lines, -13 lines	0 comments	Download
M	samplecode/samplecode_files.mk	View		2 chunks	+1 line, -13 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

reed1

LGTM http://codereview.appspot.com/4602049/diff/1/include/views/SkOSWindow_Android.h File include/views/SkOSWindow_Android.h (left): http://codereview.appspot.com/4602049/diff/1/include/views/SkOSWindow_Android.h#oldcode30 include/views/SkOSWindow_Android.h:30: I presume these are virtual, because you have ...

13 years, 6 months ago (2011-06-09 19:26:27 UTC) #2

Scroggo

http://codereview.appspot.com/4602049/diff/1/include/views/SkOSWindow_Android.h File include/views/SkOSWindow_Android.h (left): http://codereview.appspot.com/4602049/diff/1/include/views/SkOSWindow_Android.h#oldcode30 include/views/SkOSWindow_Android.h:30: On 2011/06/09 19:26:27, reed1 wrote: > I presume these ...

13 years, 6 months ago (2011-06-09 19:29:45 UTC) #3

Scroggo

http://codereview.appspot.com/4602049/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): http://codereview.appspot.com/4602049/diff/1/samplecode/SampleApp.cpp#newcode360 samplecode/SampleApp.cpp:360: bool SampleWindow::setGrContext(GrContext* context) These need #ifdef ANDROID

13 years, 6 months ago (2011-06-09 20:23:23 UTC) #4

bsalomon

13 years, 5 months ago (2011-06-13 17:11:35 UTC) #7

On 2011/06/13 16:45:16, Scroggo wrote:
> LGTM

LGTM, too. (I just looked at GrGLDefaultInterface_andriod.cpp and SampleApp.cpp)

Expand All Messages | Collapse All Messages