Issue 4589052: Proclaim we will use surrounding-text, in enable().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4589052: Proclaim we will use surrounding-text, in enable(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Daiki Ueno

Modified:
14 years ago

Reviewers:
shawn.p.huang, fujiwara, Peng

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

Description

Proclaim we will use surrounding-text, in enable(). BUG=none TEST=manually with ibus patch http://codereview.appspot.com/4613043

Patch Set 2 : check if ibus_engine_get_surrounding_text() is available #

Total comments: 1

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	src/engine.c	View	1	1 chunk	+10 lines, -0 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Peng

http://codereview.appspot.com/4589052/diff/2001/src/engine.c File src/engine.c (right): http://codereview.appspot.com/4589052/diff/2001/src/engine.c#newcode701 src/engine.c:701: #ifdef HAVE_IBUS_ENGINE_GET_SURROUNDING_TEXT Where is the HAVE_IBUS_ENGINE_GET_SURROUNDING_TEXT defined?

14 years ago (2011-06-21 15:07:19 UTC) #3

Daiki Ueno

On 2011/06/21 15:07:19, Peng wrote: > http://codereview.appspot.com/4589052/diff/2001/src/engine.c > File src/engine.c (right): > > http://codereview.appspot.com/4589052/diff/2001/src/engine.c#newcode701 > ...

14 years ago (2011-06-22 13:49:33 UTC) #4

Peng

14 years ago (2011-06-22 14:48:29 UTC) #5

On 2011/06/22 13:49:33, Daiki Ueno wrote:
> On 2011/06/21 15:07:19, Peng wrote:
> > http://codereview.appspot.com/4589052/diff/2001/src/engine.c
> > File src/engine.c (right):
> > 
> > http://codereview.appspot.com/4589052/diff/2001/src/engine.c#newcode701
> > src/engine.c:701: #ifdef HAVE_IBUS_ENGINE_GET_SURROUNDING_TEXT
> > Where is the HAVE_IBUS_ENGINE_GET_SURROUNDING_TEXT defined?
> 
> It will be defined in config.h, as a result of
> "AC_CHECK_FUNCS([ibus_engine_get_surrounding_text])" in configure.ac.

Got it. Thanks.

Expand All Messages | Collapse All Messages