Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 4587042: Additions to the Android Sample App. \ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Scroggo
Modified:
13 years ago
Reviewers:
DerekS, reed1
CC:
Leon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Moving SampleWindow into a header file. #

Patch Set 3 : Cleanup #

Patch Set 4 : Updated the README file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+425 lines, -190 lines) Patch
M android_sample/SampleApp/Android.mk View 2 chunks +3 lines, -0 lines 0 comments Download
M android_sample/SampleApp/AndroidManifest.xml View 2 chunks +2 lines, -1 line 0 comments Download
M android_sample/SampleApp/README.txt View 1 2 3 1 chunk +2 lines, -21 lines 0 comments Download
M android_sample/SampleApp/jni/sample-jni.cpp View 1 2 7 chunks +101 lines, -16 lines 0 comments Download
M android_sample/SampleApp/res/menu/sample.xml View 2 chunks +19 lines, -0 lines 0 comments Download
M android_sample/SampleApp/res/values/strings.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java View 5 chunks +62 lines, -7 lines 0 comments Download
M android_sample/SampleApp/src/com/skia/sampleapp/SampleView.java View 5 chunks +29 lines, -7 lines 0 comments Download
M include/views/SkOSWindow_Android.h View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
A samplecode/SampleApp.h View 1 1 chunk +145 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 12 chunks +56 lines, -132 lines 0 comments Download

Messages

Total messages: 6
Scroggo
13 years ago (2011-06-14 21:21:32 UTC) #1
reed1
Hmmm, we need a different pattern than extending the window baseclass with virtuals. Lets discuss ...
13 years ago (2011-06-14 21:43:27 UTC) #2
scroggo_gmail.com
How about I move the SampleWindow declaration to a header file? I suppose you had ...
13 years ago (2011-06-15 03:08:58 UTC) #3
reed1
Just laziness. Moving it to a real header sounds fine. On Tue, Jun 14, 2011 ...
13 years ago (2011-06-15 12:19:12 UTC) #4
Scroggo
On 2011/06/15 12:19:12, reed1 wrote: > Just laziness. Moving it to a real header sounds ...
13 years ago (2011-06-15 13:31:34 UTC) #5
reed1
13 years ago (2011-06-15 15:32:29 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b