Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 4580043: more gyp cleanup before The Big Switchover (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by epoger
Modified:
13 years, 5 months ago
Reviewers:
bungeman, Stephen White
CC:
bsalomon, DerekS, skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Some final cleanups leading up to The Official Switch to Gyp: 1. Create a single public skia.gyp file that all outside projects (Chrome, Android, etc.) should depend on from now on. I haven't yet created targets suitable for those projects to use, but this is where we should add them. 2. Make gyp generate its Makefiles within out/ directory, rather than polluting directories under source control. 3. Modify trunk/Makefile to automatically run gyp_skia and then call the generated Makefile, to ease developer transition.

Patch Set 1 #

Total comments: 3

Patch Set 2 : additional features for Makefile in trunk/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -315 lines) Patch
M Makefile View 1 1 chunk +31 lines, -307 lines 0 comments Download
A + Makefile.old View 1 chunk +5 lines, -0 lines 0 comments Download
M gyp/all.gyp View 1 chunk +13 lines, -0 lines 0 comments Download
M gyp/gyp_skia View 1 chunk +13 lines, -0 lines 0 comments Download
A + gyp_skia View 4 chunks +21 lines, -8 lines 0 comments Download
A skia.gyp View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 7
epoger
13 years, 5 months ago (2011-06-06 22:05:15 UTC) #1
Stephen White
http://codereview.appspot.com/4580043/diff/1/gyp_skia File gyp_skia (right): http://codereview.appspot.com/4580043/diff/1/gyp_skia#newcode78 gyp_skia:78: args.extend(['--depth', '.']) I think this will mean you can ...
13 years, 5 months ago (2011-06-06 23:37:05 UTC) #2
bungeman
Other than keeping around the deprecated files (all.gyp and gyp/gyp_skia) the rest LGTM. http://codereview.appspot.com/4580043/diff/1/gyp/all.gyp File ...
13 years, 5 months ago (2011-06-07 13:21:00 UTC) #3
epoger
On 2011/06/06 23:37:05, Stephen White wrote: > http://codereview.appspot.com/4580043/diff/1/gyp_skia > File gyp_skia (right): > > http://codereview.appspot.com/4580043/diff/1/gyp_skia#newcode78 ...
13 years, 5 months ago (2011-06-07 14:16:27 UTC) #4
epoger
Thanks, guys. I made a couple of further improvements to the toplevel Makefile; please let ...
13 years, 5 months ago (2011-06-07 14:22:43 UTC) #5
epoger
On 2011/06/07 13:21:00, bungeman wrote: > Other than keeping around the deprecated files (all.gyp and ...
13 years, 5 months ago (2011-06-07 14:23:29 UTC) #6
epoger
13 years, 5 months ago (2011-06-07 14:49:14 UTC) #7
committed as r1526
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b