Correct use of GetVersion() API.

The GetVersion() API returns the version of the os in a little-endian form: |Build Number|:16 |Minor Version|: 8 |Major Version|: 8

To compare versions, some byte swizzling is required to re-order the low and high bytes of the major/minor versions.

BUG=crbug.com/85619
TEST=None.

Committed:  http://code.google.com/p/angleproject/source/detail?r=688

[twiz, 2011-06-10 16:03:22]

Please take a look.

[dgkoch, 2011-06-10 17:50:57]

On 2011/06/10 16:03:22, twiz wrote:
> Please take a look.

Not seeing any changes here.

Perhaps we should use GetVersionEx instead?  Or at least the sample code from
MSDN:
http://msdn.microsoft.com/en-us/library/ms724439(VS.85).aspx

[twiz, 2011-06-10 17:59:58]

On 2011/06/10 17:50:57, dgkoch wrote:
> On 2011/06/10 16:03:22, twiz wrote:
> > Please take a look.
> 
> Not seeing any changes here.

Uploaded again.  Changes should be present now.

When I try to build, I'm getting conflicts with the max/min defined in WinDef.h
and std::max.  The macros of overriding the std libraries.  Is this a known
issue?  I'm using the gyp-generated projects to build.

> 
> Perhaps we should use GetVersionEx instead?  Or at least the sample code from

My changes are based off of the sample code.

> MSDN:
> http://msdn.microsoft.com/en-us/library/ms724439%28VS.85%29.aspx

[dgkoch, 2011-06-10 18:18:59]

one suggestion.  Looks ok otherwise

http://codereview.appspot.com/4579049/diff/4001/Surface.cpp
File Surface.cpp (right):

http://codereview.appspot.com/4579049/diff/4001/Surface.cpp#newcode95
Surface.cpp:95: if (mWindow && (getComparableOSVersion() >= MAKEWORD(0x00,
0x06))) {
I'd probably rather have #define or constants that have the various possible
values for the versions of windows we care about.
#define WIN_60  MAKEWORD(0x00, 0x06) 
or WIN_VISTA or something like that.

[dgkoch, 2011-06-10 18:20:24]

On 2011/06/10 17:59:58, twiz wrote:
> 
> When I try to build, I'm getting conflicts with the max/min defined in
WinDef.h
> and std::max.  The macros of overriding the std libraries.  Is this a known
> issue?  I'm using the gyp-generated projects to build.

Is this without your changes?  I'm not aware of any issues (at least not in the
standalone projects).  Can't speak for the gyp versions though.

[twiz, 2011-06-10 18:55:30]

On 2011/06/10 18:20:24, dgkoch wrote:
> On 2011/06/10 17:59:58, twiz wrote:
> > 
> > When I try to build, I'm getting conflicts with the max/min defined in
> WinDef.h
> > and std::max.  The macros of overriding the std libraries.  Is this a known
> > issue?  I'm using the gyp-generated projects to build.
> 
> Is this without your changes?  I'm not aware of any issues (at least not in
the
> standalone projects).  Can't speak for the gyp versions though.

I did some investigation:  The gyp projects are not setting the NOMINMAX define
to disable the macros.  The ANGLE.sln project has this setting.  Who uses the
gyp files?  Perhaps they are being pulled in by other gyp projects that set this
define, which is why it is not an issue.

Addressed your comments.

[twiz, 2011-06-10 19:58:00]

On 2011/06/10 18:55:30, twiz wrote:
> On 2011/06/10 18:20:24, dgkoch wrote:
> > On 2011/06/10 17:59:58, twiz wrote:
> > > 
> > > When I try to build, I'm getting conflicts with the max/min defined in
> > WinDef.h
> > > and std::max.  The macros of overriding the std libraries.  Is this a
known
> > > issue?  I'm using the gyp-generated projects to build.
> > 
> > Is this without your changes?  I'm not aware of any issues (at least not in
> the
> > standalone projects).  Can't speak for the gyp versions though.
> 
> I did some investigation:  The gyp projects are not setting the NOMINMAX
define
> to disable the macros.  The ANGLE.sln project has this setting.  Who uses the
> gyp files?  Perhaps they are being pulled in by other gyp projects that set
this
> define, which is why it is not an issue.
> 
> Addressed your comments.

I don't have commit access to Angle.  Could a committer please land this for me,
or grand me access?

[dgkoch, 2011-06-10 21:50:53]

Thanks.  LGTM.

I've added you as a committer.

[dgkoch, 2011-06-10 21:52:33]

On 2011/06/10 18:55:30, twiz wrote:
> On 2011/06/10 18:20:24, dgkoch wrote:
> > On 2011/06/10 17:59:58, twiz wrote:
> > > 
> > > When I try to build, I'm getting conflicts with the max/min defined in
> > WinDef.h
> > > and std::max.  The macros of overriding the std libraries.  Is this a
known
> > > issue?  I'm using the gyp-generated projects to build.
> > 
> > Is this without your changes?  I'm not aware of any issues (at least not in
> the
> > standalone projects).  Can't speak for the gyp versions though.
> 
> I did some investigation:  The gyp projects are not setting the NOMINMAX
define
> to disable the macros.  The ANGLE.sln project has this setting.  Who uses the
> gyp files?  Perhaps they are being pulled in by other gyp projects that set
this
> define, which is why it is not an issue.

The gyp files are used in the chrome build process, so I'd say it's fairly
likely they inherit the setting, but I've never built it that way myself.