Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(347)

Issue 4576057: Fix text-as-path with skshader on gpu (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by bsalomon
Modified:
13 years, 6 months ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : add linux baselines for shadertext #

Patch Set 3 : fix pt size for shadertext gm #

Patch Set 4 : fix gm ctx size #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -17 lines) Patch
M gm/base-linux/complexclip_gpu.png View 1 2 3 Binary file 0 comments Download
M gm/base-linux/gradients_gpu.png View 1 2 3 Binary file 0 comments Download
M gm/base-linux/points_gpu.png View 1 2 3 Binary file 0 comments Download
M gm/base-linux/shadertext_4444.png View 1 Binary file 0 comments Download
M gm/base-linux/shadertext_565.png View 1 Binary file 0 comments Download
M gm/base-linux/shadertext_8888.png View 1 Binary file 0 comments Download
M gm/base-linux/shadertext_gpu.png View 1 Binary file 0 comments Download
M gm/base-linux/strokerects_gpu.png View 1 2 3 Binary file 0 comments Download
M gm/gmmain.cpp View 1 2 3 3 chunks +15 lines, -3 lines 0 comments Download
M gm/shadertext.cpp View 1 2 3 3 chunks +18 lines, -5 lines 0 comments Download
M gpu/include/GrTextContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/src/GrTextContext.cpp View 3 chunks +19 lines, -6 lines 1 comment Download
M samplecode/SampleShaderText.cpp View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 3
bsalomon
Shaded text-as-path was broken in Gr because we lost our tweaks to the sampler matrices ...
13 years, 6 months ago (2011-06-13 21:28:05 UTC) #1
reed1
Suggesting a comment. LGTM http://codereview.appspot.com/4576057/diff/4002/gpu/src/GrTextContext.cpp File gpu/src/GrTextContext.cpp (right): http://codereview.appspot.com/4576057/diff/4002/gpu/src/GrTextContext.cpp#newcode117 gpu/src/GrTextContext.cpp:117: /* We need to call ...
13 years, 6 months ago (2011-06-13 21:41:26 UTC) #2
bsalomon
13 years, 6 months ago (2011-06-13 21:56:02 UTC) #3
Checked in with comment at r1575
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b