Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(596)

Issue 4576045: Do not set a WNDPROC on a window created by another thread. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by apatrick1
Modified:
12 years, 11 months ago
Reviewers:
nduca, dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Do not set a WNDPROC on a window created by another thread. It turns out SetWindowLong succeeds for other threads in the same process but we do not want the WNDPROC to be called from threads other than the thread on which EGL is running on. This was one of the reasons --in-process-gpu was not working with ANGLE in Chrome. Committed: http://code.google.com/p/angleproject/source/detail?r=677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -31 lines) Patch
M src/libEGL/Surface.cpp View 2 chunks +47 lines, -31 lines 0 comments Download

Messages

Total messages: 5
apatrick1
12 years, 11 months ago (2011-06-06 22:12:52 UTC) #1
nduca
LGTM. As an aside, this whole subclassing business is starting to be more and more ...
12 years, 11 months ago (2011-06-06 22:24:12 UTC) #2
apatrick1
On 2011/06/06 22:24:12, nduca wrote: > LGTM. > > As an aside, this whole subclassing ...
12 years, 11 months ago (2011-06-06 22:25:56 UTC) #3
dgkoch
LGTM. (Note that ANGLE is not currently multithreaded safe anyhow).
12 years, 11 months ago (2011-06-07 00:28:22 UTC) #4
apatrick1
12 years, 11 months ago (2011-06-07 00:36:13 UTC) #5
On 2011/06/07 00:28:22, dgkoch wrote:
> (Note that ANGLE is not currently multithreaded safe anyhow).

Yeah, that's why this change was necessary. Chrome issues GL calls from the a
spceial thread in the browser process (not the UI thread that created the
window) when run with --in-process-gpu.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b