Consider hw render target limit for offscreen supersample and tile

[reed1, 2011-06-06 11:53:37]

Does the new code respect GR_MAX_OFFSCREEN_AA_DIM at all? I had put that there
partly to allow chrome to decide when to enable this via its userconfig or .gyp

[Stephen White, 2011-06-06 14:49:19]

LGTM, but I defer to Mike.

http://codereview.appspot.com/4575041/diff/2001/gpu/src/GrGpuGL.cpp
File gpu/src/GrGpuGL.cpp (right):

http://codereview.appspot.com/4575041/diff/2001/gpu/src/GrGpuGL.cpp#newcode445
gpu/src/GrGpuGL.cpp:445: // attachmnent, hence this min:
attachmnent -> attachment

http://codereview.appspot.com/4575041/diff/2001/gpu/src/GrGpuGL.cpp#newcode448
gpu/src/GrGpuGL.cpp:448: /* The iPhone 4 has a restriction that for an FBO with
texture color
Is this code still present?  The comment seems to be orphaned.

[bsalomon, 2011-06-07 14:41:09]

>Does the new code respect GR_MAX_OFFSCREEN_AA_DIM at all?

Yup, it takes the min of the hw limit and this value:

fMaxAAOffscreenSize = GrMin(GR_MAX_OFFSCREEN_AA_DIM, gpuMaxOffscreen);

http://codereview.appspot.com/4575041/diff/2001/gpu/src/GrGpuGL.cpp
File gpu/src/GrGpuGL.cpp (right):

http://codereview.appspot.com/4575041/diff/2001/gpu/src/GrGpuGL.cpp#newcode445
gpu/src/GrGpuGL.cpp:445: // attachmnent, hence this min:
On 2011/06/06 14:49:20, Stephen White wrote:
> attachmnent -> attachment

Done.

http://codereview.appspot.com/4575041/diff/2001/gpu/src/GrGpuGL.cpp#newcode448
gpu/src/GrGpuGL.cpp:448: /* The iPhone 4 has a restriction that for an FBO with
texture color
On 2011/06/06 14:49:20, Stephen White wrote:
> Is this code still present?  The comment seems to be orphaned.

Yeah, its the two loops below that try RTs with a small width/height.

[bsalomon, 2011-06-13 13:44:10]

I updated this CL to include tiling of the super-sampler. PTAL.

I deliberately renamed GR_MAX_OFFSCREEN_DIM to GR_MAX_OFFSCREEN_SIZE. It is now
the cutover point for tiling. Using the old name would have made the skia roll a
pain because of where I moved the default definition to (GrConfig) and where
chrome currently overrides the default.

[reed1, 2011-06-13 13:49:23]

code is LGTM, waiting on results of gm and bench

[bsalomon, 2011-06-13 18:11:30]

Checked in at r1568 (code + linux baseline images) and r1569 (mac baseline
images)