Issue 4574041: Update and alphabetize contributors list.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4574041: Update and alphabetize contributors list. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by baustin

Modified:
13 years, 5 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Update and alphabetize contributors list. Committed: http://code.google.com/p/angleproject/source/detail?r=670

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	CONTRIBUTORS	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
	M	src/common/version.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dgkoch

Oh you're using *that* alphabet.. Don't forget to bump the version number in src/common/version.h as ...

13 years, 5 months ago (2011-06-03 18:08:30 UTC) #2

baustin

On 2011/06/03 18:08:30, dgkoch wrote: > Oh you're using *that* alphabet.. > > Don't forget ...

13 years, 5 months ago (2011-06-03 19:42:13 UTC) #3

dgkoch

13 years, 5 months ago (2011-06-03 20:55:42 UTC) #4

On 2011/06/03 19:42:13, baustin wrote:
> On 2011/06/03 18:08:30, dgkoch wrote:
> > Oh you're using *that* alphabet..
> > 
> > Don't forget to bump the version number in  src/common/version.h as well.
> 
> Done.  So, does the version number need to be manually updated for every
submit?
>  That seems rather error-prone.
> 
Yes it does and it is.  Don't know how to automate it though.  I'm open to
suggestions.

> http://codereview.appspot.com/4574041/diff/1/CONTRIBUTORS
> File CONTRIBUTORS (right):
> 
> http://codereview.appspot.com/4574041/diff/1/CONTRIBUTORS#newcode20
> CONTRIBUTORS:20: N. Duca
> On 2011/06/03 18:08:30, dgkoch wrote:
> > Can you fill out the "N" too?  I haven't been able to figure that one out
yet.
> 
> Done.

Thanks.
LGTM

Expand All Messages | Collapse All Messages