Issue 4571048: GCC 4.6 fix: intptr_t <-> NULL triggers a warning

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4571048: GCC 4.6 fix: intptr_t <-> NULL triggers a warning (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Ryan Sleevi

Modified:
13 years, 3 months ago

Reviewers:
thakis, bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/gpu/

Visibility:
Public.

GCC 4.6 fix: intptr_t <-> NULL triggers an warning. BUG=chromium:87001 TEST=none

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	src/GrContext.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/app-android.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/skia/SkUIView.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4

Ryan Sleevi

PTAL. GrPlatform3DContext is declared as a typedef to an intptr_t, which triggers the following warning ...

13 years, 3 months ago (2011-06-07 04:43:43 UTC) #1

Ryan Sleevi

bsalomon, reed: Would one of you mind taking a look? Thakis is not familiar enough ...

13 years, 3 months ago (2011-06-07 04:58:37 UTC) #2

Landed in r1538. Thanks for the patch!