Issue 4564052: Updated sample app to include pipe writer using file I/O

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4564052: Updated sample app to include pipe writer using file I/O (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by yangsu

Modified:
13 years, 4 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Turn off GPIPE by default. Put FILE_PIPE definition inside a ifdef #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -3 lines)			Patch
	M	samplecode/SampleApp.cpp	View	1	4 chunks	+22 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

no need to checkin your xcode proj for SampleApp.cpp 1. Lets keep the default to ...

13 years, 4 months ago (2011-06-01 17:07:26 UTC) #2

yangsu

I have turned GPIPE off by default. I also put the FILE_PIPE definition inside a ...

13 years, 4 months ago (2011-06-01 17:33:35 UTC) #3

reed1

13 years, 4 months ago (2011-06-01 17:39:04 UTC) #4

Maybe we wait until we enable it by default to checkin a new proj.

On Wed, Jun 1, 2011 at 1:33 PM,  <yangsu@google.com> wrote:
> I have turned GPIPE off by default. I also put the FILE_PIPE definition
> inside a ifdef so that it can only be defined when GPIPE is used.
>
> Would it be useful if I update the xcode project file to include the new
> tests and include the sources files for pipe reader and pipe writer?
> Because the project file currently will not compile if the TEST_GPIPE
> flag is turned on.
>
> On 2011/06/01 17:07:26, reed1 wrote:
>>
>> no need to checkin your xcode proj
>
>> for SampleApp.cpp
>
>> 1. Lets keep the default to not enable the GPIPE code
>> 2. Can your version successfully work with and without the FILE_PIPE
>
> defined?
>
>
>
> http://codereview.appspot.com/4564052/
>

Expand All Messages | Collapse All Messages