Allows glissandi to span multiple lines.

Allows line spanners to span multiple lines.

[MikeSol, 2011-05-28 08:22:00]

Hey all,

A colleague of mine is working on a piece where he needs glissandi to span
multiple lines.  I made this change and it seems to work.  Lemme know if you
think it may break something else.  I'll run regtests today or tomorrow.

To test this patch, do:


\relative c''' { \override Staff . Glissando #'breakable = ##t
<< { s2 a2 \glissando \break s1 \break s1 \break s1 \pageBreak \break s2 c,2 }
\\
{ c1 \glissando \break s1 \break s1 \break s1 \pageBreak \break e,1 } >>
}


Cheers,
MS

[Graham Percival, 2011-05-28 12:02:19]

On Sat, May 28, 2011 at 08:22:01AM +0000, mtsolo@gmail.com wrote:
> Description:
> Allows line spanners to span multiple lines.
> 
> Please review this at http://codereview.appspot.com/4564042/

Thanks, added as
http://code.google.com/p/lilypond/issues/detail?id=1673

Cheers,
- Graham

[Graham Percival (old account), 2011-05-28 12:27:26]

Have you run a regtest comparison?  I was doing a routine on this (and your
other patch at the same time), and paper-margins-consistency.ly just borked.

I'm now also missing my GNUmakefile.in, which is *extremely* suspicious because
there's no way that running "make check" should delete that file... so if you've
already done the regtest comparison, then let's just put this down to my hard
drive dying or something.

Excuse me while I go do some backing up...

[Graham Percival (old account), 2011-05-28 19:40:26]

Could we get that example as a regtest?

The regtest comparison shows some warnings in rest-polyphonic2.ly in a different
place.  I don't know if that's significant.  Nothing else changed.

[MikeSol, 2011-05-29 20:10:12]

On 2011/05/28 19:40:26, Graham Percival wrote:
> Could we get that example as a regtest?
> 
> The regtest comparison shows some warnings in rest-polyphonic2.ly in a
different
> place.  I don't know if that's significant.  Nothing else changed.

I ran the regtests and they look squeaky clean.  Lemme know if it's OK to push.

Cheers,
MS

[Keith, 2011-05-29 22:20:29]

This fails the "sniff test" because it removes some careful-looking code no
explanation as to how the job of the old code is being done.

What happens if the line on the next page is does not, in fact, have the same
vertical reference point?

\relative c''' { \override Staff . Glissando #'breakable = ##t
  { s3 a2 \glissando \break s1 \break s1 \break s1 \pageBreak \break s2
c,2\trill\fermata^\ff }
}

I suppose a misaligned glissando is better than no glissando, but the old code
made my the voice-change lines point to the right places:
\paper {ragged-right = ##t }
\new PianoStaff <<
  \new Staff = "one" {
    \showStaffSwitch
    c'1 \break
    \change Staff = "two"
    b2 a
  }
  \new Staff = "two" {
    \clef bass
    g'1^\trill^\f s1
  }
>>

[mike_apollinemike.com, 2011-05-30 07:38:19]

On May 30, 2011, at 12:20 AM, k-ohara5a5a@oco.net wrote:

> This fails the "sniff test" because it removes some careful-looking code
> no explanation as to how the job of the old code is being done.
> 
> What happens if the line on the next page is does not, in fact, have the
> same vertical reference point?
> 
> \relative c''' { \override Staff . Glissando #'breakable = ##t
>  { s3 a2 \glissando \break s1 \break s1 \break s1 \pageBreak \break s2
> c,2\trill\fermata^\ff }
> }
> 
> I suppose a misaligned glissando is better than no glissando, but the
> old code made my the voice-change lines point to the right places:
> \paper {ragged-right = ##t }
> \new PianoStaff <<
>  \new Staff = "one" {
>    \showStaffSwitch
>    c'1 \break
>    \change Staff = "two"
>    b2 a
>  }
>  \new Staff = "two" {
>    \clef bass
>    g'1^\trill^\f s1
>  }
> 

The problem doesn't come from the page break but from alignment with common Ys.

Line 242ish of line-spanner.cc is:

  do
    span_points[d][Y_AXIS] += common_y[d]->relative_coordinate (my_common_y,
Y_AXIS);
  while (flip (&d) != LEFT);

The value added on will be different depending on what's on the staves.  Try:

\relative c''' { \override Staff . Glissando #'breakable = ##t
 s2 a2 \glissando \break s1 \break s1 \break s1 \break s2
c,2
}

versus

\relative c''' { \override Staff . Glissando #'breakable = ##t
 s2 a2 \glissando \break s1 \break s1 \break s1 \break s2
c,2 \trill\fermata^\ff
}

I'm flying to Ireland today & will attempt to crunch this during the flight.

Cheers,
MS

[Graham Percival (old account), 2011-06-24 14:28:52]

On 2011/05/30 07:38:19, mike_apollinemike.com wrote:
> I'm flying to Ireland today & will attempt to crunch this during the flight.

This was almost a month ago.  Are you sailing to Ireland instead of flying?  ;)

What's the status of this patch?  If you think that draft 2 is correct, then
I'll add it to the next patch countdown.

[mike_apollinemike.com, 2011-06-24 14:35:44]

Sorry - this patch is obsolete.  The new one is at:

http://codereview.appspot.com/4527086

Sorry for not having removed the old one, and yes, please add the new one to the
countdown (it has gone through a round of commentary).

Cheers,
MS

On Jun 24, 2011, at 4:28 PM, percival.music.ca@gmail.com wrote:

> On 2011/05/30 07:38:19, mike_apollinemike.com wrote:
>> I'm flying to Ireland today & will attempt to crunch this during the
> flight.
> 
> This was almost a month ago.  Are you sailing to Ireland instead of
> flying?  ;)
> 
> What's the status of this patch?  If you think that draft 2 is correct,
> then I'll add it to the next patch countdown.
> 
> 
> http://codereview.appspot.com/4564042/