Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(352)

Issue 4561059: Insert a new-line ('\n') before the #line directive in HLSL source.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by baustin
Modified:
14 years, 2 months ago
Reviewers:
dgkoch, apatrick1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Insert a new-line ('\n') before the #line directive in HLSL source. Without this, sometimes the #line directive shows up at the end of the previous line of shader source. This was causing syntax errors when trying to compile shaders during a PIX session. Committed: http://code.google.com/p/angleproject/source/detail?r=667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler/OutputHLSL.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
baustin
14 years, 2 months ago (2011-06-02 21:00:27 UTC) #1
apatrick1
LGTM. Do you need me to commit it?
14 years, 2 months ago (2011-06-02 21:39:23 UTC) #2
baustin
No thanks--I just submitted it. I've committed before so looks like I still have the ...
14 years, 2 months ago (2011-06-02 21:58:44 UTC) #3
dgkoch
14 years, 2 months ago (2011-06-03 02:23:50 UTC) #4
On 2011/06/02 21:58:44, baustin wrote:
> No thanks--I just submitted it.  I've committed before so looks like I
> still have the proper permissions, although I'm not in the
> CONTRIBUTORS file.

Since you have commit permissions, feel free to fix that :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b