code review 456043: dfa: change conditions for memrchr: only Linux has it.

dfa: change conditions for memrchr: only Linux has it.

[rsc, 2010-03-12 17:38:58]

Hello r (cc: re2-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-03-12 17:47:01]

LGTM

On Mar 12, 2010, at 9:38 AM, rsc@golang.org wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: re2-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> dfa: change conditions for memrchr: only Linux has it.
>
> Please review this at http://codereview.appspot.com/456043/show
>
> Affected files:
>  M re2/dfa.cc
>
>
> Index: re2/dfa.cc
> ===================================================================
> --- a/re2/dfa.cc
> +++ b/re2/dfa.cc
> @@ -33,8 +33,7 @@
>
> namespace re2 {
>
> -#if defined(__APPLE__) || defined(__FreeBSD__) ||  
> defined(__NetBSD__) || defined(__OpenBSD__)
> -// BSD systems lack memrchr.
> +#if !defined(__linux__)  /* only Linux seems to have memrchr */
> static void* memrchr(const void* s, int c, size_t n) {
>   const unsigned char* p = (const unsigned char*)s;
>   for (p += n; n > 0; n--)
>
>

[rsc, 2010-03-12 17:52:41]

*** Submitted as http://code.google.com/p/re2/source/detail?r=deb45325aab9 ***

dfa: change conditions for memrchr: only Linux has it.

R=r
CC=re2-dev
http://codereview.appspot.com/456043