Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 456043: code review 456043: dfa: change conditions for memrchr: only Linux has it. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by rsc
Modified:
15 years, 8 months ago
Reviewers:
CC:
r, re2-dev_googlegroups.com
Visibility:
Public.

Description

dfa: change conditions for memrchr: only Linux has it.

Patch Set 1 #

Patch Set 2 : code review 456043: dfa: change conditions for memrchr: only Linux has it. #

Patch Set 3 : code review 456043: dfa: change conditions for memrchr: only Linux has it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M re2/dfa.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r (cc: re2-dev@googlegroups.com), I'd like you to review this change.
15 years, 8 months ago (2010-03-12 17:38:58 UTC) #1
r2
LGTM On Mar 12, 2010, at 9:38 AM, rsc@golang.org wrote: > Reviewers: r, > > ...
15 years, 8 months ago (2010-03-12 17:47:01 UTC) #2
rsc
15 years, 8 months ago (2010-03-12 17:52:41 UTC) #3
*** Submitted as http://code.google.com/p/re2/source/detail?r=deb45325aab9 ***

dfa: change conditions for memrchr: only Linux has it.

R=r
CC=re2-dev
http://codereview.appspot.com/456043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b