Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1869)

Issue 4557042: Skip PDFs, move index.html to output directory, add --weighted option. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by TomH
Modified:
13 years, 6 months ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

--weighted option had never been committed; was prototyped here before implementation in WebKit ImageDiff. Stores index.html in the output directory rather than the current working directory. Skips PDFs since we can't compare those.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -28 lines) Patch
M tools/skdiff_main.cpp View 13 chunks +88 lines, -28 lines 1 comment Download

Messages

Total messages: 2
reed1
LGTM http://codereview.appspot.com/4557042/diff/1/tools/skdiff_main.cpp File tools/skdiff_main.cpp (right): http://codereview.appspot.com/4557042/diff/1/tools/skdiff_main.cpp#newcode71 tools/skdiff_main.cpp:71: static int compare_diff_weighted (DiffRecord** lhs, DiffRecord** rhs) { ...
13 years, 6 months ago (2011-05-24 19:34:34 UTC) #1
TomH
13 years, 6 months ago (2011-06-06 14:57:26 UTC) #2
Committed in r1411.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b