Issue 4556072: Added missing depth argument to GYP which causes the top-level

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4556072: Added missing depth argument to GYP which causes the top-level (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by kbr1

Modified:
12 years, 11 months ago

Reviewers:
vangelis, VangelisK

CC:
angleproject-review_googlegroups.com, nicolas, dgkoch, apatrick1

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Added missing depth argument to GYP which causes the top-level Makefile to be generated into the correct directory on Linux. Added missing library for clients of translator (the samples, in particular). Built all ANGLE targets on Linux and Windows to test these changes. BUG=none TEST=none Committed: http://code.google.com/p/angleproject/source/detail?r=664

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	build/gyp_angle	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/build_angle.gyp	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

vangelis

12 years, 11 months ago (2011-06-01 22:26:04 UTC) #2

On 2011/06/01 22:00:24, kbr1 wrote:
> Please review. Thanks.

Looks good, thanks.

Expand All Messages | Collapse All Messages