Issue 4556043: fix assertion failure in Skia_Linux_Fixed_Debug build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4556043: fix assertion failure in Skia_Linux_Fixed_Debug build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by epoger

Modified:
13 years, 8 months ago

Reviewers:
bungeman, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

The assertion failure, only for SK_DEBUG and SK_SCALAR_IS_FIXED, was: include/core/SkFixed.h:74: failed assertion "n >= -32768 && n <= 32767"

Patch Set 1 #

Total comments: 1

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	gm/shadertext.cpp	View		3 chunks	+3 lines, -4 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

13 years, 8 months ago (2011-05-20 14:44:21 UTC) #4

http://codereview.appspot.com/4556043/diff/1/gm/shadertext.cpp
File gm/shadertext.cpp (right):

http://codereview.appspot.com/4556043/diff/1/gm/shadertext.cpp#newcode14
gm/shadertext.cpp:14: int         shorterDimensionAsInt = w < h ? w : h;
SkScalar s = SkIntToScalar(SkMin32(w, h));

Expand All Messages | Collapse All Messages