Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2349)

Issue 4556043: fix assertion failure in Skia_Linux_Fixed_Debug build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by epoger
Modified:
13 years, 1 month ago
Reviewers:
bungeman, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The assertion failure, only for SK_DEBUG and SK_SCALAR_IS_FIXED, was: include/core/SkFixed.h:74: failed assertion "n >= -32768 && n <= 32767"

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M gm/shadertext.cpp View 3 chunks +3 lines, -4 lines 1 comment Download

Messages

Total messages: 4
epoger
13 years, 1 month ago (2011-05-19 15:50:04 UTC) #1
bungeman
LGTM On 2011/05/19 15:50:04, epoger wrote:
13 years, 1 month ago (2011-05-19 17:28:12 UTC) #2
epoger
committed as r1381
13 years, 1 month ago (2011-05-19 17:36:55 UTC) #3
reed1
13 years, 1 month ago (2011-05-20 14:44:21 UTC) #4
http://codereview.appspot.com/4556043/diff/1/gm/shadertext.cpp
File gm/shadertext.cpp (right):

http://codereview.appspot.com/4556043/diff/1/gm/shadertext.cpp#newcode14
gm/shadertext.cpp:14: int         shorterDimensionAsInt = w < h ? w : h;
SkScalar s = SkIntToScalar(SkMin32(w, h));
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b