Issue 4552053: Eliminate createPlatformRenderTarget. Undeprecate createRenderTargetFrom3DApiState

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4552053: Eliminate createPlatformRenderTarget. Undeprecate createRenderTargetFrom3DApiState (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by bsalomon

Modified:
13 years, 2 months ago

Reviewers:
Stephen White, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -98 lines)			Patch
M	gpu/include/GrContext.h	View	1 chunk	+3 lines, -22 lines	0 comments	Download
M	gpu/include/GrGpu.h	View	2 chunks	+0 lines, -19 lines	0 comments	Download
M	gpu/src/GrContext.cpp	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	gpu/src/GrGpu.cpp	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	gpu/src/GrGpuGL.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	gpu/src/GrGpuGL.cpp	View	1 chunk	+0 lines, -26 lines	0 comments	Download

Total messages: 3

bsalomon

The "create from api state" is just too damn handy when the call site that ...

13 years, 2 months ago (2011-05-19 21:19:13 UTC) #1

bsalomon

13 years, 2 months ago (2011-05-19 21:23:36 UTC) #3

Closing with r1387

On 2011/05/19 21:20:43, Stephen White wrote:
> LGTM
> 
> Thank you!