Issue 4552047: GrPathUtils::worstCasePointCount() returning wrong count

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4552047: GrPathUtils::worstCasePointCount() returning wrong count (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Stephen White

Modified:
13 years, 5 months ago

Reviewers:
reed, bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

GrPathUtils::worstCasePointCount() is sometimes returning a lower value than the number of points subsequently generated by the path renderers. This is because it constructs the SkPath::Iter with forceClose set to "false", while the path renderers use one with forceClose set to "true". They should both be the same, and since we're filling paths, I think it should be set "true".

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
		gpu/src/GrPathUtils.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

LGTM On 2011/05/17 18:26:32, Stephen White wrote: > PTAL

13 years, 5 months ago (2011-05-17 18:27:48 UTC) #3

Landed as r1353; closing.

Expand All Messages | Collapse All Messages