Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(213)

Issue 4552046: Fix tests to correct color order. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by bungeman
Modified:
13 years, 3 months ago
Reviewers:
junov, reed
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M bench/benchmain.cpp View 11 chunks +11 lines, -10 lines 0 comments Download
M gm/base-linux/bitmapfilters_4444.png View Binary file 0 comments Download
M gm/base-linux/bitmapfilters_565.png View Binary file 0 comments Download
M gm/base-linux/bitmapfilters_8888.png View Binary file 0 comments Download
M gm/base-linux/complexclip_pdf.pdf View Binary file 0 comments Download
M gm/base-linux/nocolorbleed_4444.png View Binary file 0 comments Download
M gm/base-linux/nocolorbleed_565.png View Binary file 0 comments Download
M gm/base-linux/nocolorbleed_8888.png View Binary file 0 comments Download
M gm/base-linux/nocolorbleed_pdf.pdf View Binary file 0 comments Download
M gm/base/bitmapfilters_4444.png View Binary file 0 comments Download
M gm/base/bitmapfilters_565.png View Binary file 0 comments Download
M gm/base/bitmapfilters_8888.png View Binary file 0 comments Download
M gm/base/bitmapfilters_gpu.png View Binary file 0 comments Download
M gm/base/nocolorbleed_4444.png View Binary file 0 comments Download
M gm/base/nocolorbleed_565.png View Binary file 0 comments Download
M gm/base/nocolorbleed_8888.png View Binary file 0 comments Download
M gm/base/nocolorbleed_gpu.png View Binary file 0 comments Download
M gm/base/nocolorbleed_pdf.pdf View Binary file 0 comments Download
M gm/bitmapfilters.cpp View 4 chunks +11 lines, -6 lines 0 comments Download
M gm/nocolorbleed.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3
bungeman
The color order wasn't swizzled. The old tests have the red and blue swapped. This ...
13 years, 3 months ago (2011-05-17 18:26:02 UTC) #1
junov
LGTM
13 years, 3 months ago (2011-05-18 15:17:12 UTC) #2
bungeman
13 years, 3 months ago (2011-05-18 18:55:49 UTC) #3
Committed revision 1367.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b