Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(230)

Issue 4551101: CueClefs: Use middleCClefPosition in the key engraver (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by Reinhold
Modified:
12 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

CueClefs: Use middleCClefPosition in the key engraver Otherwise the key signature would use the middle staff position of the cue part (so the keysignature would be printed as if it were in the cue clef rather than the real clef), which is not what we want.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
A input/regression/cue-clef-keysignature.ly View 1 chunk +24 lines, -0 lines 1 comment Download
M lily/key-engraver.cc View 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 5
Graham Percival (old account)
thanks, added as http://code.google.com/p/lilypond/issues/detail?id=1684
12 years, 11 months ago (2011-06-07 17:47:23 UTC) #1
Carl
LGTM. Carl
12 years, 11 months ago (2011-06-07 19:10:59 UTC) #2
Neil Puttock
LGTM. http://codereview.appspot.com/4551101/diff/1/input/regression/cue-clef-keysignature.ly File input/regression/cue-clef-keysignature.ly (right): http://codereview.appspot.com/4551101/diff/1/input/regression/cue-clef-keysignature.ly#newcode1 input/regression/cue-clef-keysignature.ly:1: \version "2.13.60" 2.15.2 http://codereview.appspot.com/4551101/diff/1/lily/key-engraver.cc File lily/key-engraver.cc (right): http://codereview.appspot.com/4551101/diff/1/lily/key-engraver.cc#newcode80 ...
12 years, 10 months ago (2011-06-12 14:52:15 UTC) #3
lemniskata.bernoulliego
LGTM. Btw, is it possible to download a source file from Rietveld? I'd like to ...
12 years, 10 months ago (2011-06-13 10:37:25 UTC) #4
Graham Percival (old account)
12 years, 10 months ago (2011-06-21 09:50:15 UTC) #5
LGTM, please push after making the small changes requested by Neil.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b