Issue 4551097: Use floating-point fast path in SkMatrix::computeTypeMask()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4551097: Use floating-point fast path in SkMatrix::computeTypeMask() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by TomH

Modified:
13 years, 5 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Benchmarking suggests that replacing some of the conversions from float to int with direct floating-point comparisons in computeTypeMask() is a significant win (up to 40%?). In practice, we see a 10-15% speedup in this function (the current most expensive Skia function) in Chrome on the FishIETank demo. The remainder of the function looks like it ought to be amenable to similar speedups, but we haven't found a rewrite that behaves well in benchmarking yet.

Patch Set 1 #

Patch Set 2 : Change constant to work in Fixed as well as Float #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/core/SkMatrix.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

TomH

13 years, 5 months ago (2011-06-06 17:34:51 UTC) #4

On 2011/06/06 15:18:40, TomH wrote:
> Committed in revision 1512.

SK_Scalar1 only worked in Floating Point; changed to kMatrix22Elem to also work
in Fixed Point; committed in revision 1515.

Expand All Messages | Collapse All Messages