[PDF] Fix regression - correct for fInitialTransform in form xobjects.

[PDF] Fix regression - correct for fInitialTrnasform in form xobjects.

Chrome bug http://crbug.com/83658

Committed: http://code.google.com/p/skia/source/detail?r=1415

[Chris Guillory, 2011-05-24 08:54:00]

LGTM.

Possible TODO: We may want to move this logic in the future. Perhaps the
SkPDFFormXObject constructor could request pdf device content without an initial
transform.

[Steve VanDeBogart, 2011-05-24 21:57:59]

On 2011/05/24 08:54:00, Chris Guillory wrote:
> Possible TODO: We may want to move this logic in the future. Perhaps the
> SkPDFFormXObject constructor could request pdf device content without an
initial
> transform.

Looking at this again, the first approach only fixed the symptom and not the
problem.  We can't change fInitialTransform in a SkPDFDevice after we've drawn
anything (shaders and images use it and would be wrong if it changed).  However,
we don't want to double apply the fInitialTransform on form xobjects, so we set
the matrix on the form xobject to the inverse fInitialTransform.

[Chris Guillory, 2011-05-24 22:03:36]

LGTM. Nit.

http://codereview.appspot.com/4550072/diff/4001/src/pdf/SkPDFFormXObject.cpp
File src/pdf/SkPDFFormXObject.cpp (right):

http://codereview.appspot.com/4550072/diff/4001/src/pdf/SkPDFFormXObject.cpp#...
src/pdf/SkPDFFormXObject.cpp:27: const SkMatrix& initialTransform) {
Nit: Can we add an getter for the initialTransform instead of passing it as an
argument to this constructor.

http://codereview.appspot.com/4550072/diff/4001/src/pdf/SkPDFFormXObject.cpp#...
src/pdf/SkPDFFormXObject.cpp:44: SkMatrix inverse;
If you make the change for the nit can you move the initialTransform comment
from the header here.

[Steve VanDeBogart, 2011-05-24 22:58:48]

http://codereview.appspot.com/4550072/diff/4001/src/pdf/SkPDFFormXObject.cpp
File src/pdf/SkPDFFormXObject.cpp (right):

http://codereview.appspot.com/4550072/diff/4001/src/pdf/SkPDFFormXObject.cpp#...
src/pdf/SkPDFFormXObject.cpp:27: const SkMatrix& initialTransform) {
On 2011/05/24 22:03:36, Chris Guillory wrote:
> Nit: Can we add an getter for the initialTransform instead of passing it as an
> argument to this constructor.

Done.

http://codereview.appspot.com/4550072/diff/4001/src/pdf/SkPDFFormXObject.cpp#...
src/pdf/SkPDFFormXObject.cpp:44: SkMatrix inverse;
On 2011/05/24 22:03:36, Chris Guillory wrote:
> If you make the change for the nit can you move the initialTransform comment
> from the header here.

Done.

[Chris Guillory, 2011-05-24 23:00:33]

LGTM

http://codereview.appspot.com/4550072/diff/8001/src/pdf/SkPDFFormXObject.cpp
File src/pdf/SkPDFFormXObject.cpp (right):

http://codereview.appspot.com/4550072/diff/8001/src/pdf/SkPDFFormXObject.cpp#...
src/pdf/SkPDFFormXObject.cpp:42: // We invert the initial transform and apply
that to the form so that
Optional: form -> xobject