Issue 4550057: [PDF] Implement clear xfermode with a mask instead of pushing the clip down.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4550057: [PDF] Implement clear xfermode with a mask instead of pushing the clip down. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Steve VanDeBogart

Modified:
13 years, 4 months ago

Reviewers:
Chris Guillory

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] Implement clear xfermode with a mask instead of pushing the clip down. This approach is much less likely to use an SkRegion and ends up working better for Webkit. Committed: http://code.google.com/p/skia/source/detail?r=1375

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : Address comments #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -56 lines)			Patch
	M	include/pdf/SkPDFDevice.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/pdf/SkPDFDevice.cpp	View	1	3 chunks	+38 lines, -56 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Chris Guillory

LGTM. http://codereview.appspot.com/4550057/diff/2001/include/pdf/SkPDFDevice.h File include/pdf/SkPDFDevice.h (right): http://codereview.appspot.com/4550057/diff/2001/include/pdf/SkPDFDevice.h#newcode169 include/pdf/SkPDFDevice.h:169: // Clear the passed clip from all existing ...

13 years, 4 months ago (2011-05-18 22:57:59 UTC) #1

Steve VanDeBogart

13 years, 4 months ago (2011-05-18 23:04:46 UTC) #2

http://codereview.appspot.com/4550057/diff/2001/include/pdf/SkPDFDevice.h
File include/pdf/SkPDFDevice.h (right):

http://codereview.appspot.com/4550057/diff/2001/include/pdf/SkPDFDevice.h#new...
include/pdf/SkPDFDevice.h:169: // Clear the passed clip from all existing
drawing.
On 2011/05/18 22:57:59, Chris Guillory wrote:
> Nit: Can this comment be more specific?

Done.

Expand All Messages | Collapse All Messages