Issue 4548051: Warn when an SkScalar is passed into SkIntToScalar() (converted twice)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4548051: Warn when an SkScalar is passed into SkIntToScalar() (converted twice) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by epoger

Modified:
13 years, 3 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Mike suggested this, and it's clever, but it didn't catch any cases where we pass SkScalar to SkIntToScalar(), even though there are some! That's because, at least in the cases I found, the SkScalar was being (silently, implicitly) cast to int before being passed into SkIntToScalar(). See http://codereview.appspot.com/4556043/

Patch Set 1 #

Patch Set 2 : fix indent #

Patch Set 3 : added comments #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -3 lines)			Patch
	M	gm/shadertext.cpp	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
	M	include/core/SkScalar.h	View	1 2	2 chunks	+38 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

epoger

added comments, and Mike's suggestion from http://codereview.appspot.com/4556043/

13 years, 3 months ago (2011-05-20 15:34:32 UTC) #2

committed as r1405

Expand All Messages | Collapse All Messages