[PDF] Add plumbing and accessors so that Chrome can record the font types used in a PDF

[PDF] Add plumbing and accessors so that Chrome can record the font types used in a PDF.

- Add a font type accessor to SkPDFFont.
- Plumb font resource retrivial up to SkPDFPage.

Committed: http://code.google.com/p/skia/source/detail?r=1444

[Chris Guillory, 2011-05-28 22:28:00]

http://codereview.appspot.com/4547069/diff/1/include/pdf/SkPDFDocument.h
File include/pdf/SkPDFDocument.h (right):

http://codereview.appspot.com/4547069/diff/1/include/pdf/SkPDFDocument.h#newc...
include/pdf/SkPDFDocument.h:53: *  to each object.  The resulting list will be
unique.
Does getFontResources() on the pdf device also add a reference to each object?
Seems like the reference pattern should be the same for the two functions since
their names are so similar.

[Steve VanDeBogart, 2011-05-28 22:32:29]

On 2011/05/28 22:28:00, Chris Guillory wrote:
> http://codereview.appspot.com/4547069/diff/1/include/pdf/SkPDFDocument.h
> File include/pdf/SkPDFDocument.h (right):
> 
>
http://codereview.appspot.com/4547069/diff/1/include/pdf/SkPDFDocument.h#newc...
> include/pdf/SkPDFDocument.h:53: *  to each object.  The resulting list will be
> unique.
> Does getFontResources() on the pdf device also add a reference to each object?
> Seems like the reference pattern should be the same for the two functions
since
> their names are so similar.

Yea, I noticed that too.  Getting in Skia shouldn't inc ref.  so the Device/Page
methods follow that convention.  Looking at the Chrome side, I probably won't
need the changes to SkPDFDocument.

[Steve VanDeBogart, 2011-05-29 00:13:52]

Please take a look.  This works with the Chrome side now.

[Chris Guillory, 2011-05-29 01:30:46]

LGTM

[Chris Guillory, 2011-05-29 01:30:47]

LGTM