Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(119)

Issue 4547063: Fix the bug that long varying varibales are mapped into different names in fragment/vertex shaders. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by Zhenyao Mo
Modified:
14 years, 3 months ago
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix the bug that long varying varibales are mapped into different names in fragment/vertex shaders. ANGLEBUG=144 TEST=the same long varying variable name in fragment/vertex shaders map to the same shortened name if using the same translator. Committed: http://code.google.com/p/angleproject/source/detail?r=660

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
M src/common/version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/Compiler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/MapLongVariableNames.h View 2 chunks +6 lines, -1 line 1 comment Download
M src/compiler/MapLongVariableNames.cpp View 2 chunks +39 lines, -4 lines 0 comments Download
M src/compiler/ShHandle.h View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 5
Zhenyao Mo
Please review.
14 years, 3 months ago (2011-05-26 23:11:12 UTC) #1
kbr1
LGTM; nice work. Perhaps Nicolas should take a look too. http://codereview.appspot.com/4547063/diff/1/src/compiler/ShHandle.h File src/compiler/ShHandle.h (right): http://codereview.appspot.com/4547063/diff/1/src/compiler/ShHandle.h#newcode94 ...
14 years, 3 months ago (2011-05-27 02:14:40 UTC) #2
Zhenyao Mo
Alok, Nicolas, any further review comments? On Thu, May 26, 2011 at 7:14 PM, <kbr@chromium.org> ...
14 years, 3 months ago (2011-05-27 03:59:47 UTC) #3
nicolas
Looks fine to me.
14 years, 3 months ago (2011-05-27 14:54:04 UTC) #4
Alok Priyadarshi
14 years, 3 months ago (2011-05-27 15:07:21 UTC) #5
lgtm

http://codereview.appspot.com/4547063/diff/1/src/compiler/MapLongVariableNames.h
File src/compiler/MapLongVariableNames.h (right):

http://codereview.appspot.com/4547063/diff/1/src/compiler/MapLongVariableName...
src/compiler/MapLongVariableNames.h:22: MapLongVariableNames(TMap<TString,
TString>& varyingLongNameMap);
const argument?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b