Now on both mac and linux!
LGTM aside from minor nits. We have a general rule of wrapping at 80 cols unless the result is clearly much uglier than not wrapping. http://codereview.appspot.com/4545055/diff/1005/gpu/src/mesa/GrGLDefaultInter... File gpu/src/mesa/GrGLDefaultInterface_mesa.cpp (right): http://codereview.appspot.com/4545055/diff/1005/gpu/src/mesa/GrGLDefaultInter... gpu/src/mesa/GrGLDefaultInterface_mesa.cpp:107: gDefaultInterface.fTexImage2D = reinterpret_cast<GrGLTexImage2DProc>(glTexImage2D); Let's put a comment about this here // On Mac's OSMESA glTexImage2D takes a GLenum for internaFormat rather than a GLint. or something like that http://codereview.appspot.com/4545055/diff/1005/src/utils/mesa/SkEGLContext_M... File src/utils/mesa/SkEGLContext_Mesa.cpp (right): http://codereview.appspot.com/4545055/diff/1005/src/utils/mesa/SkEGLContext_M... src/utils/mesa/SkEGLContext_Mesa.cpp:22: #if SK_B32_SHIFT < SK_G32_SHIFT && SK_G32_SHIFT < SK_R32_SHIFT && SK_R32_SHIFT < SK_A32_SHIFT line wraps?
Committed revision 1382.