Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(304)

Issue 4545049: Fix winding order issues w/GrTesselatedPathRender (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by Stephen White
Modified:
13 years, 6 months ago
Reviewers:
reed, bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The isCCW() code in GrTesselatedPathRenderer was using untransformed vertices, which fails for transforms with negative scale. Doing the check after transformation fixes it. This was causing some missing geometry in the PolyToPoly and Shapes tests in SampleApp.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
gpu/src/GrTesselatedPathRenderer.cpp View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3
Stephen White
13 years, 6 months ago (2011-05-16 15:58:57 UTC) #1
bsalomon
LGTM On 2011/05/16 15:58:57, Stephen White wrote:
13 years, 6 months ago (2011-05-16 16:50:12 UTC) #2
Stephen White
13 years, 6 months ago (2011-05-16 17:00:11 UTC) #3
Landed as r1334; closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b