Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(783)

Issue 45420044: Lexer/Parser: Don't package location data in SCM_TOKEN semantic value (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by dak
Modified:
10 years, 2 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Lexer/Parser: Don't package location data in SCM_TOKEN semantic value As the location data is available as the location value in the parser anyway, there is no point in packaging it into the semantic value. Among other things, this leads to a cleaner display when using -ddebug-parser, and to better understandable code.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -66 lines) Patch
M lily/include/lily-lexer.hh View 1 chunk +6 lines, -2 lines 0 comments Download
M lily/include/parse-scm.hh View 1 chunk +7 lines, -14 lines 0 comments Download
M lily/lexer.ll View 5 chunks +12 lines, -14 lines 0 comments Download
M lily/parse-scm.cc View 7 chunks +34 lines, -31 lines 0 comments Download
M lily/parser.yy View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 1
lemzwerg
10 years, 4 months ago (2014-01-02 08:29:06 UTC) #1
LGTM, from mere inspection.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b