Issue 45420043: Doc: NR - Tidy up of 3.5.1 and 3.5.3 - MIDI

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 45420043: Doc: NR - Tidy up of 3.5.1 and 3.5.3 - MIDI (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by pkx166h

Modified:
10 years, 4 months ago

Reviewers:
Ian Hulin (gmail)

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Doc: NR - Tidy up of 3.5.1 and 3.5.3 - MIDI Seemed some of this information was repeeated (and so redundant) with additional grammar and sentence structure changes and more consistent @examples. Merged 3.5.3 into 3.5.1, with @seealsos added No new technical information added.

Patch Set 1 #

Total comments: 2

Patch Set 2 : with Ian's suggestions #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -109 lines)			Patch
	M	Documentation/notation/input.itely	View	1	4 chunks	+67 lines, -109 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Ian Hulin (gmail)

LGTM apart from clarification needed that the \midi { \tempo ..} } example explicitly only ...

10 years, 4 months ago (2013-12-25 00:02:49 UTC) #1

pkx166h

Thanks Ian. https://codereview.appspot.com/45420043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/45420043/diff/1/Documentation/notation/input.itely#newcode2695 Documentation/notation/input.itely:2695: quarter-note beats per minute. On 2013/12/25 00:02:49, ...

10 years, 4 months ago (2013-12-26 07:33:59 UTC) #3

pkx166h

10 years, 4 months ago (2013-12-31 07:34:49 UTC) #4

author	James Lowe <pkx166h@gmail.com>	
	Tue, 24 Dec 2013 18:56:29 +0000 (18:56 +0000)
committer	James Lowe <pkx166h@gmail.com>	
	Tue, 31 Dec 2013 07:09:23 +0000 (07:09 +0000)
commit	d6ec297c78a548291854efe5573388cd4e2c4d72

Expand All Messages | Collapse All Messages