Issue 4539101: Generate an error in the parser for unsized array declarations.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4539101: Generate an error in the parser for unsized array declarations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by kbr1

Modified:
12 years, 11 months ago

Reviewers:
nicolas, Alok Priyadarshi

CC:
angleproject-review_googlegroups.com, dgkoch, Zhenyao Mo

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Generate an error in the parser for unsized array declarations. BUG=164 TEST=none Committed: http://code.google.com/p/angleproject/source/detail?r=666

Patch Set 2 : '' #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -47 lines)			Patch
	M	src/compiler/glslang.y	View	1	1 chunk	+3 lines, -18 lines	0 comments	Download
	M	src/compiler/glslang_tab.cpp	View	1	2 chunks	+14 lines, -29 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Alok Priyadarshi

lgtm http://codereview.appspot.com/4539101/diff/1/src/compiler/glslang.y File src/compiler/glslang.y (right): http://codereview.appspot.com/4539101/diff/1/src/compiler/glslang.y#newcode1299 src/compiler/glslang.y:1299: if (context->structQualifierErrorCheck($2.line, $1)) I think you can remove ...

12 years, 11 months ago (2011-06-02 17:40:29 UTC) #2

kbr1

12 years, 11 months ago (2011-06-02 18:41:18 UTC) #3

On 2011/06/02 17:40:29, Alok Priyadarshi wrote:
> lgtm
> 
> http://codereview.appspot.com/4539101/diff/1/src/compiler/glslang.y
> File src/compiler/glslang.y (right):
> 
>
http://codereview.appspot.com/4539101/diff/1/src/compiler/glslang.y#newcode1299
> src/compiler/glslang.y:1299: if (context->structQualifierErrorCheck($2.line,
> $1))
> I think you can remove everything in this arm from here.
> 
>
http://codereview.appspot.com/4539101/diff/1/src/compiler/glslang.y#newcode1305
> src/compiler/glslang.y:1305: $$.type = $1;
> except this.

Thanks, that seems to work. Uploaded the final patch.

Expand All Messages | Collapse All Messages