Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1094)

Issue 4539072: Grab-bag of memory fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by Stephen White
Modified:
13 years, 6 months ago
Reviewers:
bsalomon, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

SkFlatMatrix::Flatten had the same issue as Sk2DPathEffect: it was encoding a partially-unintialized matrix type mask. The others are simply uninitialized vars in the sample code.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Responding to Mike's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
samplecode/SampleHairline.cpp View 1 chunk +1 line, -0 lines 0 comments Download
samplecode/SampleLineClipper.cpp View 1 chunk +1 line, -0 lines 0 comments Download
src/core/SkPictureFlat.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Stephen White
13 years, 6 months ago (2011-05-20 19:52:58 UTC) #1
Stephen White
ping?
13 years, 6 months ago (2011-05-24 18:59:12 UTC) #2
reed1
http://codereview.appspot.com/4539072/diff/1/src/core/SkPictureFlat.cpp File src/core/SkPictureFlat.cpp (right): http://codereview.appspot.com/4539072/diff/1/src/core/SkPictureFlat.cpp#newcode35 src/core/SkPictureFlat.cpp:35: buffer.flatten(result->fMatrixData); I think we can avoid the overhead of ...
13 years, 6 months ago (2011-05-24 19:31:21 UTC) #3
Stephen White
Responding to Mike's comments
13 years, 6 months ago (2011-05-24 20:16:34 UTC) #4
reed1
LGTM
13 years, 6 months ago (2011-05-24 20:19:40 UTC) #5
Stephen White
13 years, 6 months ago (2011-05-24 20:30:12 UTC) #6
Landed as r1414.  Closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b