Issue 4539048: Remove thumb check for _builtin_clz

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4539048: Remove thumb check for _builtin_clz

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Shankar

Modified:
8 years, 10 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This patch removes the thumb check for clz implementation

Patch Set 1 #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/core/SkMath.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Shankar

Remove the check of __thumb__ for ARM, for core with thumb-2 (-march=armv7-a -mthumb) clz is ...

13 years, 1 month ago (2011-05-11 04:12:27 UTC) #1

Shankar

Hi Reed, Could you please checkin the changes ? thanks Shankar

13 years, 1 month ago (2011-05-17 12:28:20 UTC) #4

Shankar

13 years, 1 month ago (2011-06-03 03:41:07 UTC) #6

Thanks a lot Reed

-shankar

On Thu, Jun 2, 2011 at 7:15 PM,  <reed@google.com> wrote:
> committed rev. 1477
>
> http://codereview.appspot.com/4539048/
>

Expand All Messages | Collapse All Messages