Issue 4539045: [PDF] Fix ending condition for font advance construction.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4539045: [PDF] Fix ending condition for font advance construction. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Steve VanDeBogart

Modified:
13 years, 7 months ago

Reviewers:
Chris Guillory

CC:
skia-review_googlegroups.com, arthurhsu

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] Fix ending condition for font advance construction. The old code always ended (the last sequence of glyphs) on a range, even if there was a very long run at the end. This fixes that. Committed: http://code.google.com/p/skia/source/detail?r=1293

Patch Set 1 #

Patch Set 2 : Change to a fix that doesn't copy a big chunk of code #

Patch Set 3 : Fix bug #

Total comments: 2

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -4 lines)			Patch
	M	src/core/SkAdvancedTypefaceMetrics.cpp	View	1 2	5 chunks	+18 lines, -4 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Chris Guillory

LGTM. One comment. http://codereview.appspot.com/4539045/diff/3002/src/core/SkAdvancedTypefaceMetrics.cpp File src/core/SkAdvancedTypefaceMetrics.cpp (right): http://codereview.appspot.com/4539045/diff/3002/src/core/SkAdvancedTypefaceMetrics.cpp#newcode122 src/core/SkAdvancedTypefaceMetrics.cpp:122: if (curRange->fStartId == num_glyphs) { Should ...

13 years, 7 months ago (2011-05-10 23:19:11 UTC) #3

Steve VanDeBogart

http://codereview.appspot.com/4539045/diff/3002/src/core/SkAdvancedTypefaceMetrics.cpp File src/core/SkAdvancedTypefaceMetrics.cpp (right): http://codereview.appspot.com/4539045/diff/3002/src/core/SkAdvancedTypefaceMetrics.cpp#newcode122 src/core/SkAdvancedTypefaceMetrics.cpp:122: if (curRange->fStartId == num_glyphs) { On 2011/05/10 23:19:12, Chris ...

13 years, 7 months ago (2011-05-10 23:24:03 UTC) #4

Chris Guillory

13 years, 7 months ago (2011-05-10 23:24:32 UTC) #5

On 2011/05/10 23:24:03, Steve VanDeBogart wrote:
>
http://codereview.appspot.com/4539045/diff/3002/src/core/SkAdvancedTypefaceMe...
> File src/core/SkAdvancedTypefaceMetrics.cpp (right):
> 
>
http://codereview.appspot.com/4539045/diff/3002/src/core/SkAdvancedTypefaceMe...
> src/core/SkAdvancedTypefaceMetrics.cpp:122: if (curRange->fStartId ==
> num_glyphs) {
> On 2011/05/10 23:19:12, Chris Guillory wrote:
> > Should this also verify that prevRange is non-NULL (edge case where
num_glyphs
> > is 0).
> 
> If num_glyphs is 0, then something before this is probably going to break
> anyway.
Fair enough.

Expand All Messages | Collapse All Messages