Issue 4536109: Add functional tests for patch and fields

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4536109: Add functional tests for patch and fields (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by jcgregorio_google

Modified:
13 years, 3 months ago

Reviewers:
ade

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
	M	functional_tests/test_services.py	View		1 chunk	+39 lines, -0 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ade

Apart from the test name: LGTM http://codereview.appspot.com/4536109/diff/1/functional_tests/test_services.py File functional_tests/test_services.py (right): http://codereview.appspot.com/4536109/diff/1/functional_tests/test_services.py#newcode145 functional_tests/test_services.py:145: def test_fields(self): Could ...

13 years, 3 months ago (2011-06-06 13:36:21 UTC) #2

jcgregorio_google

http://codereview.appspot.com/4536109/diff/1/functional_tests/test_services.py File functional_tests/test_services.py (right): http://codereview.appspot.com/4536109/diff/1/functional_tests/test_services.py#newcode145 functional_tests/test_services.py:145: def test_fields(self): On 2011/06/06 13:36:21, ade wrote: > Could ...

13 years, 3 months ago (2011-06-06 13:42:24 UTC) #3

jcgregorio_google

13 years, 3 months ago (2011-06-06 13:43:34 UTC) #4

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=694dd6ff2bc...

On 2011/06/06 13:42:24, jcgregorio_google wrote:
> http://codereview.appspot.com/4536109/diff/1/functional_tests/test_services.py
> File functional_tests/test_services.py (right):
> 
>
http://codereview.appspot.com/4536109/diff/1/functional_tests/test_services.p...
> functional_tests/test_services.py:145: def test_fields(self):
> On 2011/06/06 13:36:21, ade wrote:
> > Could you change the name of this method to be clearer that it's verifying
> that
> > only the requested feeds are returned.
> 
> Done.

Expand All Messages | Collapse All Messages