Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2724)

Issue 4536096: create GYP files for these targets: tests, gm, skhello, skimage, skdiff (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by epoger
Modified:
13 years, 5 months ago
Reviewers:
bungeman, Stephen White
CC:
bsalomon, reed1, TomH, skia-review_googlegroups.com, senorblanco
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Created GYP files for remaining targets. I have tested the following for each of these targets on Linux: - Create and run makefile for each target independently ./gyp_skia tests.gyp && make out/Debug/tests - Create makefile for all targets and build a single target ./gyp_skia && make tests out/Debug/tests - Create makefile for and build all targets at once ./gyp_skia && make all out/Debug/tests I have also generated Visual Studio (MSVS) projects for all targets and they look reasonable, but I haven't tried building them in Visual Studio yet. I haven't tried to do anything with XCode targets yet.

Patch Set 1 #

Patch Set 2 : merged thru r1471 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -17 lines) Patch
M gyp/all.gyp View 1 1 chunk +10 lines, -1 line 0 comments Download
A gyp/apptype_console.gypi View 1 chunk +27 lines, -0 lines 0 comments Download
M gyp/bench.gyp View 1 3 chunks +10 lines, -16 lines 2 comments Download
M gyp/core.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
A gyp/gm.gyp View 1 chunk +52 lines, -0 lines 0 comments Download
M gyp/images.gyp View 1 1 chunk +8 lines, -0 lines 2 comments Download
A gyp/tests.gyp View 1 chunk +95 lines, -0 lines 2 comments Download
A gyp/tools.gyp View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 6
epoger
13 years, 5 months ago (2011-06-01 03:07:30 UTC) #1
epoger
+senorblanco
13 years, 5 months ago (2011-06-01 03:10:20 UTC) #2
bungeman
On 2011/06/01 03:10:20, epoger wrote: > +senorblanco LGTM
13 years, 5 months ago (2011-06-02 13:56:23 UTC) #3
Stephen White
LGTM. http://codereview.appspot.com/4536096/diff/3001/gyp/bench.gyp File gyp/bench.gyp (right): http://codereview.appspot.com/4536096/diff/3001/gyp/bench.gyp#newcode4 gyp/bench.gyp:4: # ./gyp_skia bench.gyp && make Just out of ...
13 years, 5 months ago (2011-06-02 14:10:52 UTC) #4
epoger
Thanks, guys. Committing now. http://codereview.appspot.com/4536096/diff/3001/gyp/bench.gyp File gyp/bench.gyp (right): http://codereview.appspot.com/4536096/diff/3001/gyp/bench.gyp#newcode4 gyp/bench.gyp:4: # ./gyp_skia bench.gyp && make ...
13 years, 5 months ago (2011-06-02 14:35:04 UTC) #5
epoger
13 years, 5 months ago (2011-06-02 14:39:51 UTC) #6
committed as r1479
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b