Issue 4536080: Rename glu libtess symbols

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4536080: Rename glu libtess symbols (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Stephen White

Modified:
13 years, 4 months ago

Reviewers:
bsalomon, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

When enabled in WebKit, the internal_glu libtess symbols in skia will collide with the same internal_ implementation in WebKit. Rename the glu entry points with an Sk_ prefix instead. Also, unfork the changes to the libtess source as much as possible (the same as was done in http://trac.webkit.org/changeset/87178).

Patch Set 1 #

Patch Set 2 : Same as the above, but without the sk_glu rename (rietveld choked on it). #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -66 lines)			Patch
gpu/src/GrTesselatedPathRenderer.cpp	View		2 chunks	+14 lines, -14 lines	0 comments	Download
third_party/glu/README.skia	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download
third_party/glu/gluos.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
third_party/glu/libtess/geom.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
third_party/glu/libtess/memalloc.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
third_party/glu/libtess/mesh.h	View		1 chunk	+1 line, -1 line	0 comments	Download
third_party/glu/libtess/mesh.c	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
third_party/glu/libtess/normal.c	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
third_party/glu/libtess/priorityq.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
third_party/glu/libtess/priorityq-heap.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
third_party/glu/libtess/render.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
third_party/glu/libtess/sweep.c	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
third_party/glu/libtess/tess.h	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
third_party/glu/libtess/tess.c	View	1	13 chunks	+18 lines, -19 lines	0 comments	Download
third_party/glu/libtess/tessmono.c	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Stephen White

Same as the above, but without the sk_glu rename (rietveld choked on it).

13 years, 4 months ago (2011-05-24 21:33:25 UTC) #2

Landed as r1419.  Closing.

Expand All Messages | Collapse All Messages