Issue 4535113: Fix prediction sample to comply with updated insert request and take data as command line flag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4535113: Fix prediction sample to comply with updated insert request and take data as command line flag

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by rkaplow

Modified:
13 years, 3 months ago

Reviewers:
jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 2 : Fix prediction sample to comply with updated insert request and take data as command line flag #

Total comments: 1

Patch Set 3 : Fix prediction sample to comply with updated insert request and take data as command line flag #

Patch Set 4 : Fix prediction sample to comply with updated insert request and take data as command line flag #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+475 lines, -12 lines)			Patch
A	samples/prediction/README	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	samples/prediction/language_id.txt	View	1 2 3	1 chunk	+451 lines, -0 lines	0 comments	Download
M	samples/prediction/prediction.py	View	1 2	5 chunks	+13 lines, -9 lines	0 comments	Download
M	samples/prediction/setup.sh	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jcgregorio_google

Also add a README file that explains they need to run setup.sh before running prediction.py. ...

13 years, 3 months ago (2011-06-02 18:44:06 UTC) #1

jcgregorio_google

LGTM http://codereview.appspot.com/4535113/diff/4001/samples/prediction/prediction.py File samples/prediction/prediction.py (right): http://codereview.appspot.com/4535113/diff/4001/samples/prediction/prediction.py#newcode77 samples/prediction/prediction.py:77: 'Full Google Storage path of .csv data (ex. ...

13 years, 3 months ago (2011-06-02 19:35:59 UTC) #3

jcgregorio_google

13 years, 3 months ago (2011-06-06 13:00:56 UTC) #4

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=8ba7d001527...

On 2011/06/02 19:35:59, jcgregorio_google wrote:
> LGTM
> 
>
http://codereview.appspot.com/4535113/diff/4001/samples/prediction/prediction.py
> File samples/prediction/prediction.py (right):
> 
>
http://codereview.appspot.com/4535113/diff/4001/samples/prediction/prediction...
> samples/prediction/prediction.py:77: 'Full Google Storage path of .csv data
(ex.
> bucket/object)')
> 80 chars

Expand All Messages | Collapse All Messages