Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2001)

Issue 4535085: Clean up some valgrind errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Stephen White
Modified:
13 years, 5 months ago
Reviewers:
reed, bsalomon, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Valgrind complains about overlapping memcpy() in SkTransparentShader. In fact, it seems that src and dest are the same, so we should be able to skip the copy in this case.

Patch Set 1 #

Patch Set 2 : Let's call it src instead #

Patch Set 3 : For realz this time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
src/effects/SkTransparentShader.cpp View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Stephen White
13 years, 5 months ago (2011-05-18 21:11:08 UTC) #1
Stephen White
Let's call it src instead
13 years, 5 months ago (2011-05-18 21:13:36 UTC) #2
Stephen White
For realz this time
13 years, 5 months ago (2011-05-18 21:14:50 UTC) #3
reed1
good catch. LGTM
13 years, 5 months ago (2011-05-20 19:00:58 UTC) #4
Stephen White
13 years, 5 months ago (2011-05-20 19:12:58 UTC) #5
Landed as r1393.  Closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b