Issue 4535075: Use SkSetFourByteTag in SkFontHost_win.cpp.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4535075: Use SkSetFourByteTag in SkFontHost_win.cpp. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Chris Guillory

Modified:
13 years, 1 month ago

Reviewers:
Steve VanDeBogart, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Use SkSetFourByteTag in SkFontHost_win.cpp. Committed: http://code.google.com/p/skia/source/detail?r=1340

Patch Set 3 : '' #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/ports/SkFontHost_win.cpp	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Steve VanDeBogart

http://codereview.appspot.com/4535075/diff/1/src/ports/SkFontHost_win.cpp File src/ports/SkFontHost_win.cpp (right): http://codereview.appspot.com/4535075/diff/1/src/ports/SkFontHost_win.cpp#newcode87 src/ports/SkFontHost_win.cpp:87: SkEndian_SwapBE16(SkSetFourByteTag('m', 'a', 'x', 'p')); SwapBE32 ? http://codereview.appspot.com/4535075/diff/1/src/ports/SkFontHost_win.cpp#newcode795 src/ports/SkFontHost_win.cpp:795: SkEndian_SwapBE16(SkSetFourByteTag('t', ...

13 years, 1 month ago (2011-05-16 21:52:50 UTC) #2

Chris Guillory

13 years, 1 month ago (2011-05-16 21:57:09 UTC) #3

LGTM

Expand All Messages | Collapse All Messages