Issue 4532108: Redid gyp changes in last commit to support debugging of samples on

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4532108: Redid gyp changes in last commit to support debugging of samples on (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by kbr1

Modified:
12 years, 11 months ago

Reviewers:
vangelis, VangelisK

CC:
angleproject-review_googlegroups.com, nicolas, dgkoch

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Redid gyp changes in last commit to support debugging of samples on Linux. Fixed bug in translator sample where it was confusing arguments and filenames on POSIX platforms. Committed: http://code.google.com/p/angleproject/source/detail?r=665

Patch Set 1 #

Total comments: 1

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -9 lines)			Patch
M	build/common.gypi	View	1 chunk	+26 lines, -1 line	1 comment	Download
M	samples/translator/translator.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/build_angle.gyp	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

vangelis

One question, otherwise LGTM http://codereview.appspot.com/4532108/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.appspot.com/4532108/diff/1/build/common.gypi#newcode101 build/common.gypi:101: 'Debug': { Do you need ...

12 years, 11 months ago (2011-06-02 00:08:54 UTC) #2

kbr1

12 years, 11 months ago (2011-06-02 00:23:15 UTC) #3

On 2011/06/02 00:08:54, vangelis wrote:
> One question, otherwise LGTM
> 
> http://codereview.appspot.com/4532108/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
> http://codereview.appspot.com/4532108/diff/1/build/common.gypi#newcode101
> build/common.gypi:101: 'Debug': {
> Do you need to set flags and defines for the 'Release' config?

I don't think we need to do this right now. When built inside of Chromium, ANGLE
picks up the surrounding environment's build flags. The only major problem I ran
into was that the standalone Linux executables weren't debuggable.

Expand All Messages | Collapse All Messages