GYP fixes

Add a missing include path for the linux build of utils.gyp.  Remove the Linux utils files from the build of views.a, since they're already being compiled into utils.a, since it was causing unnecessary rebuilds (the same could probably be done for linux and mac).  Remove the commented-out SkImageDecoder_libpvjpeg.cpp, which has been removed from SVN.

[epoger, 2011-06-01 20:29:15]

http://codereview.appspot.com/4532105/diff/1/gyp/all.gyp
File gyp/all.gyp (right):

http://codereview.appspot.com/4532105/diff/1/gyp/all.gyp#newcode5
gyp/all.gyp:5: 'target_name': 'All',
I think you should revert this part of the change.

I patched your complete CL into a local workspace, and here's what happened:
$ cd trunk/gyp
$ rm -rf Makefile *.mk *.Makefile out
$ ./gyp_skia && make all
Updating projects from gyp files...
make: Nothing to be done for `all'.

I reverted this file, and it worked again:
$ svn revert all.gyp
$ rm -rf Makefile *.mk *.Makefile out
$ ./gyp_skia && make all
Updating projects from gyp files...
  CXX(target) out/Debug/obj.target/core/../src/core/Sk64.o
  CXX(target) out/Debug/obj.target/core/../src/core/SkAdvancedTypefaceMetrics.o
  CXX(target) out/Debug/obj.target/core/../src/core/SkAlphaRuns.o
  CXX(target) out/Debug/obj.target/core/../src/core/SkBitmap.o
[...]

[Stephen White, 2011-06-01 20:35:23]

http://codereview.appspot.com/4532105/diff/1/gyp/all.gyp
File gyp/all.gyp (right):

http://codereview.appspot.com/4532105/diff/1/gyp/all.gyp#newcode5
gyp/all.gyp:5: 'target_name': 'All',
On 2011/06/01 20:29:15, epoger wrote:
> I think you should revert this part of the change.
> 
> I patched your complete CL into a local workspace, and here's what happened:
> $ cd trunk/gyp
> $ rm -rf Makefile *.mk *.Makefile out
> $ ./gyp_skia && make all
> Updating projects from gyp files...
> make: Nothing to be done for `all'.

Hmm.  "make All" would work (or just "make").  The problem is, the Makefile
generator already has an "all" target, and creating one of our own adds a cyclic
dependency.  Do we absolutely need a target called "all"?  (btw, I stole this
fix from Chrome's all.gyp, which presumably had the same problem).

> 
> I reverted this file, and it worked again:
> $ svn revert all.gyp
> $ rm -rf Makefile *.mk *.Makefile out
> $ ./gyp_skia && make all
> Updating projects from gyp files...
>   CXX(target) out/Debug/obj.target/core/../src/core/Sk64.o
>   CXX(target)
out/Debug/obj.target/core/../src/core/SkAdvancedTypefaceMetrics.o
>   CXX(target) out/Debug/obj.target/core/../src/core/SkAlphaRuns.o
>   CXX(target) out/Debug/obj.target/core/../src/core/SkBitmap.o
> [...]

[epoger, 2011-06-01 20:45:23]

http://codereview.appspot.com/4532105/diff/1/gyp/all.gyp
File gyp/all.gyp (right):

http://codereview.appspot.com/4532105/diff/1/gyp/all.gyp#newcode5
gyp/all.gyp:5: 'target_name': 'All',
On 2011/06/01 20:35:23, Stephen White wrote:
> On 2011/06/01 20:29:15, epoger wrote:
> > I think you should revert this part of the change.
> > 
> > I patched your complete CL into a local workspace, and here's what happened:
> > $ cd trunk/gyp
> > $ rm -rf Makefile *.mk *.Makefile out
> > $ ./gyp_skia && make all
> > Updating projects from gyp files...
> > make: Nothing to be done for `all'.
> 
> Hmm.  "make All" would work (or just "make").  The problem is, the Makefile
> generator already has an "all" target, and creating one of our own adds a
cyclic
> dependency.  Do we absolutely need a target called "all"?  (btw, I stole this
> fix from Chrome's all.gyp, which presumably had the same problem).
> 
> > 
> > I reverted this file, and it worked again:
> > $ svn revert all.gyp
> > $ rm -rf Makefile *.mk *.Makefile out
> > $ ./gyp_skia && make all
> > Updating projects from gyp files...
> >   CXX(target) out/Debug/obj.target/core/../src/core/Sk64.o
> >   CXX(target)
> out/Debug/obj.target/core/../src/core/SkAdvancedTypefaceMetrics.o
> >   CXX(target) out/Debug/obj.target/core/../src/core/SkAlphaRuns.o
> >   CXX(target) out/Debug/obj.target/core/../src/core/SkBitmap.o
> > [...]
> 

Nope, just "make" doesn't work either with your change.  "make All" does, but
People Will Complain.

$ rm -rf Makefile *.mk *.Makefile out
$ ./gyp_skia && make
Updating projects from gyp files...
make: Nothing to be done for `all'.
$ ./gyp_skia && make All
Updating projects from gyp files...
  CXX(target) out/Debug/obj.target/core/../src/core/Sk64.o
  CXX(target) out/Debug/obj.target/core/../src/core/SkAdvancedTypefaceMetrics.o
 ...

Can you please tell me more about these "warnings from the make
backend"?  I haven't seen them...

[Stephen White, 2011-06-01 20:50:09]

On 2011/06/01 20:45:23, epoger wrote:
> Nope, just "make" doesn't work either with your change.  "make All" does, but
> People Will Complain.

You're right -- make doesn't work either.  I'll revert the all.gyp change.

> Can you please tell me more about these "warnings from the make
> backend"?  I haven't seen them...

senorblanco-mon:~/src/skia2/gyp> make
make: Circular all <- all dependency dropped.
make: Nothing to be done for `all'.
senorblanco-mon:~/src/skia2/gyp>

It's probably benign.  It was just bugging me and I thought the fix was easy. 
Not so..

[Stephen White, 2011-06-01 20:50:57]

Revert all.gyp changes

[epoger, 2011-06-01 20:54:20]

LGTM

[Stephen White, 2011-06-01 20:56:02]

On 2011/06/01 20:50:57, Stephen White wrote:
> Revert all.gyp changes

Landed as r1476.  Closing.