Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 4532081: Fix a new clang warning: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by thakis
Modified:
12 years, 9 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/src/
Visibility:
Public.

Description

Fix a new clang warning: third_party/skia/src/ports/SkFontHost_FreeType.cpp:957:7:error: switch case is in protected scope default: ^ third_party/skia/src/ports/SkFontHost_FreeType.cpp:918:17: note: jump bypasses variable initialization FT_BBox bbox; ^ third_party/skia/src/ports/SkFontHost_FreeType.cpp:946:7:error: switch case is in protected scope case FT_GLYPH_FORMAT_BITMAP: ^ third_party/skia/src/ports/SkFontHost_FreeType.cpp:918:17: note: jump bypasses variable initialization FT_BBox bbox; ^ 2 errors generated. This is arguably a false positive, but since |bbox| can only safely be used in the first case branch, it's a good idea to scope it to there anyway. This is the only instance this warning occurs in all of chrome.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ports/SkFontHost_FreeType.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
thakis
This is blocking the next clang roll.
13 years, 6 months ago (2011-05-24 03:25:28 UTC) #1
Steve VanDeBogart
LGTM
13 years, 6 months ago (2011-05-24 05:16:51 UTC) #2
reed1
13 years, 6 months ago (2011-05-24 19:32:03 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b